Draft
Conversation
Completed the initial setup for the new Real Estate module. Created the base directory structure and manifest. Successfully installed the module. Initialized model and model fields which generates tables using odoo ORM
|
|
sopat-odoo
force-pushed
the
19.0-tutorials-estate-sopat
branch
from
c704669 to
8470d17
Compare
Fixed warnings and errors raised by the first push. Created security/ir.model.access.csv file in estate for defining access rights. Added the data in csv file and defined the csv file in manifest.
sopat-odoo
force-pushed
the
19.0-tutorials-estate-sopat
branch
from
8470d17 to
15ba5f8
Compare
Created estate_property_views.xml for the window action. Implemented 3-level menu structure: Root, Advertisements, and Properties. Linked the menu to the window action to enable UI navigation.
sopat-odoo
force-pushed
the
19.0-tutorials-estate-sopat
branch
from
73b35ae to
730af93
Compare
Added readonly and copy=False attributes to selling_price field. Set default value of 2 for bedrooms field. Set default availability date to 3 months from today using Date.add(). Added active reserved field with default=True for record visibility. Added state reserved field with specific values.
sopat-odoo
force-pushed
the
19.0-tutorials-estate-sopat
branch
from
730af93 to
aab2bd1
Compare
Added list view with key property fields for display. Added form view with grouped fields and description tab. Added search view with title and postcode search fields. Added Available filter using date_availability domain. Added Group By postcode option in search view.
mash-odoo
requested changes
Mar 17, 2026
mash-odoo
left a comment
mash-odoo
left a comment
There was a problem hiding this comment.
Hello!
Great start on the app..
Here are a few comments..mostly nits..
Also please update the PR title
|
|
||
|
|
||
| class EstateProperty(models.Model): | ||
| _name = "estate.property" |
There was a problem hiding this comment.
Suggested change
| _name = "estate.property" | |
| _name = 'estate.property' |
keep technical string in single quotes.
Comment on lines
+21
to
+26
| garden_orientation = fields.Selection( | ||
| string='Orientation', | ||
| selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')], | ||
| help="The direction the garden faces." | ||
|
|
||
| ) |
There was a problem hiding this comment.
Suggested change
| garden_orientation = fields.Selection( | |
| string='Orientation', | |
| selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')], | |
| help="The direction the garden faces." | |
| ) | |
| garden_orientation = fields.Selection( | |
| string="Orientation", | |
| selection=[('north', "North"), ('south', "South"), ('east', "East"), ('west', "West")], | |
| help="The direction the garden faces." | |
| ) |
Functional strings (the strings which are shown to user) should be in double quotes.
Comment on lines
+28
to
+34
| selection=[ | ||
| ('new', 'New'), | ||
| ('offer_received', 'Offer Received'), | ||
| ('offer_accepted', 'Offer Accepted'), | ||
| ('sold', 'Sold'), | ||
| ('canceled', 'Cancelled'), | ||
| ], |
estate/models/estate_property.py
Outdated
| copy=False, | ||
| default='new', | ||
| ) | ||
|
No newline at end of file |
There was a problem hiding this comment.
Always add an extra line at the end of the file.
| 'views/estate_property_views.xml', | ||
| 'views/estate_menus.xml', | ||
| ], | ||
| 'installable': True, |
There was a problem hiding this comment.
Whats the purpose of writing installable true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed the initial setup for the new Real Estate module. Created the base directory structure and manifest. Successfully installed the module.
Initialized model and model fields which generates tables using odoo ORM